Skip to content

Conversation

jog1t
Copy link
Contributor

@jog1t jog1t commented Sep 8, 2025

No description provided.

Copy link
Contributor Author

jog1t commented Sep 8, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

claude bot commented Sep 8, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link

vercel bot commented Sep 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
engine-test-runner Error Error Sep 18, 2025 9:57pm
rivet-cloud Error Error Sep 18, 2025 9:57pm
rivet-site Ready Ready Preview Comment Sep 18, 2025 9:57pm
rivet-studio Ready Ready Preview Comment Sep 18, 2025 9:57pm

isLoading,
isError,
refetch,
} = useInfiniteQuery(projectsQueryOptions());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The projectsQueryOptions() function requires an orgId parameter but is being called without arguments. This will cause a runtime error when the component renders. The correct usage should be:

projectsQueryOptions({ orgId: organization })

This ensures the query has the necessary organization context to fetch the correct projects.

Suggested change
} = useInfiniteQuery(projectsQueryOptions());
} = useInfiniteQuery(projectsQueryOptions({ orgId: organization }));

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

export const NamespaceNameId = z.string().brand();
export type NamespaceNameId = z.infer<typeof NamespaceNameId>;

export const projectsQueryOptions = ({ orgId }: { orgId: string }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The projectsQueryOptions function is defined with a required orgId parameter, but it's called without this parameter in the project detail page. This will cause TypeScript errors and potential runtime issues. Consider either:

  1. Making the parameter optional with a default value:

    export const projectsQueryOptions = ({ orgId }: { orgId?: string } = {}) => {
  2. Or ensuring all calls to this function provide the required parameter:

    useInfiniteQuery(projectsQueryOptions({ orgId: organization }))

This will ensure type safety and prevent potential runtime errors when fetching project data.

Suggested change
export const projectsQueryOptions = ({ orgId }: { orgId: string }) => {
export const projectsQueryOptions = ({ orgId }: { orgId?: string } = {}) => {

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Comment on lines +22 to +24
await queryClient.invalidateQueries({
...projectsQueryOptions(),
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The projectsQueryOptions() function requires an orgId parameter but is being called without arguments. This will cause a runtime error since the function signature expects { orgId: string }. Consider passing the organization ID from the route params or context:

await queryClient.invalidateQueries({
  ...projectsQueryOptions({ orgId: values.organizationId }),
});
Suggested change
await queryClient.invalidateQueries({
...projectsQueryOptions(),
});
await queryClient.invalidateQueries({
...projectsQueryOptions({ orgId: values.organizationId }),
});

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Comment on lines +37 to +38
console.log(await clerk.session?.getToken());
return (await clerk.session?.getToken()) || "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Concern: The console.log statement on line 21 of manager-cloud.ts is exposing authentication tokens in the browser console. This presents a security risk as sensitive authentication data could be exposed to anyone with access to the developer tools.

console.log(await clerk.session?.getToken());

Recommendation: Remove this console.log statement entirely or replace it with appropriate debug logging that doesn't expose the actual token value. Authentication tokens should never be logged in production code.

Suggested change
console.log(await clerk.session?.getToken());
return (await clerk.session?.getToken()) || "";
return (await clerk.session?.getToken()) || "";

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

import { zodValidator } from "@tanstack/zod-adapter";
import { C } from "node_modules/@clerk/clerk-react/dist/useAuth-BVxIa9U7.mjs";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import appears to be referencing an internal module path with a hash suffix (node_modules/@clerk/clerk-react/dist/useAuth-BVxIa9U7.mjs), which is likely an implementation detail of the build system. Such imports are unstable across package versions and could break during dependency updates.

Consider importing from the public API surface instead:

import { useAuth } from "@clerk/clerk-react";

If this import is needed for a specific reason, it would be better to document why and consider creating a wrapper that could be updated if the internal path changes.

Suggested change
import { C } from "node_modules/@clerk/clerk-react/dist/useAuth-BVxIa9U7.mjs";
import { useAuth } from "@clerk/clerk-react";

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Copy link
Contributor

graphite-app bot commented Sep 8, 2025

Graphite Automations

"Test" took an action on this PR • (09/08/25)

1 assignee was added to this PR based on Kacper Wojciechowski's automation.

@jog1t jog1t changed the base branch from main to graphite-base/2882 September 8, 2025 22:41
@jog1t jog1t mentioned this pull request Sep 8, 2025
@jog1t jog1t force-pushed the graphite-base/2882 branch from fe6d7a9 to 746212f Compare September 8, 2025 22:41
@jog1t jog1t force-pushed the 09-08-feat_cloud_projects branch from f5f0bfd to ed2b820 Compare September 8, 2025 22:41
@jog1t jog1t changed the base branch from graphite-base/2882 to 09-06-feat_fe_handle_runners_unavailability September 8, 2025 22:41
Copy link

claude bot commented Sep 8, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link

claude bot commented Sep 8, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link

pkg-pr-new bot commented Sep 8, 2025

Open in StackBlitz

npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner@2882
npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner-protocol@2882
npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-tunnel-protocol@2882

commit: 1a053df

Copy link

pkg-pr-new bot commented Sep 8, 2025

Open in StackBlitz

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner@2882
npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner-protocol@2882
npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-tunnel-protocol@2882

commit: ed2b820

Copy link

claude bot commented Sep 12, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link

claude bot commented Sep 12, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@jog1t jog1t changed the base branch from main to graphite-base/2882 September 18, 2025 19:25
@jog1t jog1t force-pushed the 09-08-feat_cloud_projects branch from 44b0828 to cd5411f Compare September 18, 2025 19:25
@jog1t jog1t changed the base branch from graphite-base/2882 to 09-18-fix_circumvent_fern_bug_with_utoipa_config September 18, 2025 19:25
Copy link

claude bot commented Sep 18, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link

claude bot commented Sep 18, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@jog1t jog1t force-pushed the 09-18-fix_circumvent_fern_bug_with_utoipa_config branch from 2a5dc9d to f4a6c03 Compare September 18, 2025 21:31
@jog1t jog1t force-pushed the 09-08-feat_cloud_projects branch from cd5411f to 1a053df Compare September 18, 2025 21:31
Copy link

claude bot commented Sep 18, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link

claude bot commented Sep 18, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants