Skip to content

Conversation

NathanFlurry
Copy link
Member

@NathanFlurry NathanFlurry commented Sep 8, 2025

Fixes RVT-5133

Fixes RVT-5120

Copy link

vercel bot commented Sep 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-cloud Error Error Sep 16, 2025 8:34am
rivet-site Ready Ready Preview Comment Sep 16, 2025 8:34am
rivet-studio Ready Ready Preview Comment Sep 16, 2025 8:34am

Copy link
Member Author

NathanFlurry commented Sep 8, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

linear bot commented Sep 8, 2025

Copy link

claude bot commented Sep 8, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link

claude bot commented Sep 8, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@NathanFlurry NathanFlurry force-pushed the 09-06-chore_pegboard_consolidate_to_single_subscriber_per_gateway branch from 4881e7e to 34cf689 Compare September 8, 2025 07:04
Copy link

claude bot commented Sep 8, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link

linear bot commented Sep 8, 2025

Copy link
Contributor

@MasterPtato MasterPtato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont understand why we need a single sub for the gateway

@@ -40,7 +49,7 @@ pub const POSTGRES_MAX_MESSAGE_SIZE: usize =
pub struct PostgresDriver {
pool: Arc<Pool>,
client: Arc<tokio_postgres::Client>,
subscriptions: Cache<String, Subscription>,
subscriptions: Arc<Mutex<HashMap<String, Subscription>>>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see why this change was made, it makes contention a much higher probability

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misunderstood what Cache was. Will fix in RVT-5138

@NathanFlurry
Copy link
Member Author

I dont understand why we need a single sub for the gateway

Reduced overhead for starting requests bc you dont need to create an extra sub. I think NATS is optimized so this isn't as big a deal but PG it certainly is

@NathanFlurry NathanFlurry force-pushed the 09-06-chore_pegboard_consolidate_to_single_subscriber_per_gateway branch from 34cf689 to 858c193 Compare September 9, 2025 03:30
@NathanFlurry NathanFlurry force-pushed the 09-06-chore_ups_add_benches branch from 3586f1c to f68b17f Compare September 9, 2025 03:30
Copy link

claude bot commented Sep 9, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link

claude bot commented Sep 9, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link

claude bot commented Sep 9, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link

claude bot commented Sep 14, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link

claude bot commented Sep 15, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@MasterPtato MasterPtato removed their request for review September 15, 2025 17:55
@MasterPtato MasterPtato force-pushed the 09-06-chore_pegboard_consolidate_to_single_subscriber_per_gateway branch from 0ecbe78 to 9d88491 Compare September 15, 2025 18:04
Copy link

claude bot commented Sep 15, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@NathanFlurry NathanFlurry merged commit 2916549 into main Sep 16, 2025
3 of 10 checks passed
@NathanFlurry NathanFlurry deleted the 09-06-chore_pegboard_consolidate_to_single_subscriber_per_gateway branch September 16, 2025 08:01
Copy link

claude bot commented Sep 16, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants