-
Notifications
You must be signed in to change notification settings - Fork 114
chore(pegboard): consolidate to single subscriber per gateway #2879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pegboard): consolidate to single subscriber per gateway #2879
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Claude encountered an error —— View job I'll analyze this and get back to you. |
4881e7e
to
34cf689
Compare
Claude encountered an error —— View job I'll analyze this and get back to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont understand why we need a single sub for the gateway
@@ -40,7 +49,7 @@ pub const POSTGRES_MAX_MESSAGE_SIZE: usize = | |||
pub struct PostgresDriver { | |||
pool: Arc<Pool>, | |||
client: Arc<tokio_postgres::Client>, | |||
subscriptions: Cache<String, Subscription>, | |||
subscriptions: Arc<Mutex<HashMap<String, Subscription>>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont see why this change was made, it makes contention a much higher probability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misunderstood what Cache
was. Will fix in RVT-5138
Reduced overhead for starting requests bc you dont need to create an extra sub. I think NATS is optimized so this isn't as big a deal but PG it certainly is |
34cf689
to
858c193
Compare
3586f1c
to
f68b17f
Compare
Claude encountered an error —— View job I'll analyze this and get back to you. |
Claude encountered an error —— View job I'll analyze this and get back to you. |
858c193
to
c84e8b5
Compare
f68b17f
to
d6b0b65
Compare
Claude encountered an error —— View job I'll analyze this and get back to you. |
0ecbe78
to
5e0abe2
Compare
Claude encountered an error —— View job I'll analyze this and get back to you. |
5e0abe2
to
0ecbe78
Compare
Claude encountered an error —— View job I'll analyze this and get back to you. |
0ecbe78
to
9d88491
Compare
Claude encountered an error —— View job I'll analyze this and get back to you. |
…ubscriber_per_gateway
Claude encountered an error —— View job I'll analyze this and get back to you. |
Fixes RVT-5133
Fixes RVT-5120