Fix 4357 - Properly catch and throw the error encountered while compiling bad schema #4723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2025
heath-freenome
force-pushed
the
fix-4357
branch
2 times, most recently
from
c7a8388 to
a32a428
Compare
nickgros
approved these changes
Aug 18, 2025
heath-freenome
force-pushed
the
fix-4357
branch
from
a32a428 to
bce8f92
Compare
…ling bad schema Fixed rjsf-team#4357 by properly catching the error caused by trying to compile a bad schema in the validator - Updated `validator.ts` to move the `this.ajv.getSchema()` call inside of the try/catch to deal with bad schemas properly - Updated the `RawValidatorTest.tsx` component to add a replacer function to the `JSON.stringify()` function to properly output the `validationError` - Updated `CHANGELOG.md` accordingly
heath-freenome
force-pushed
the
fix-4357
branch
from
bce8f92 to
33c961b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixed #4357 by properly catching the error caused by trying to compile a bad schema in the validator
validator.tsto move thethis.ajv.getSchema()call inside of the try/catch to deal with bad schemas properlyRawValidatorTest.tsxcomponent to add a replacer function to theJSON.stringify()function to properly output thevalidationErrorCHANGELOG.mdaccordinglyBefore:
After:
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.