Don't bind most HAL functions/types by default #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
virtuald
commented
Dec 8, 2025
virtuald
commented
- Teams shouldn't use them and it's just extra maintainer effort
- Also fix AddressableLEDSim getData/setData, remove HAL type
- Teams shouldn't use them and it's just extra maintainer effort
auscompgeek
approved these changes
Dec 8, 2025
Member
auscompgeek
left a comment
auscompgeek
left a comment
There was a problem hiding this comment.
LGTM. Honestly I think if there's any functions needed for some reason, cffi will probably provide more efficient bindings, but we can look at that when the time comes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.