Library linking order #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, LGTM. Thanks. BTW, one big change that I made in semiwrap is that all the YAML files need to have the full namespace in them for classes, so I wrote a script to make the migration easier. |
|
This has actually been a weird issue for many years, so I was just adding all of the libraries to each dependent wrapper. Ha! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the list of libraries gathered started with the libraries included in the package, then the dependency libraries were gathered. This list was finally reversed before being returned.
This causes an issue where the libraries included in the package are listed last when linking the final shared library and all of the dependencies are listed before that. Because of this, the symbols in the package libraries are not resolved.
I have modified it so that the package libraries are added to the list, then the dependencies, in reverse order, are added to the list.
P.S. - I know that you've migrated to semiwrap, and I intend to do this as well. But I was several libraries in when that migration started, so I decided to finish the robotpy-build wrapping first before migrating!