Skip to content

Library linking order #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

Library linking order #260

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d68facb
Adjust how library names are gathered so that linking is done in the …
patrick-wolfram Jun 3, 2025
7f49f69
Removing unnecessary line.
patrick-wolfram Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions robotpy_build/wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,15 +307,17 @@ def _all_library_dirs(self):
return libs

def _all_library_names(self):
libs = list(
set(self.get_library_names()) | set(self.get_dlopen_library_names())
)
libs = []
[libs.append(lib) for lib in self.get_library_names() if lib not in libs]
[libs.append(lib) for lib in self.get_dlopen_library_names() if lib not in libs]
dep_libs = []
for dep in self.cfg.depends:
pkg = self.pkgcfg.get_pkg(dep)
libnames = pkg.get_library_names()
if libnames:
libs.extend(libnames)
return list(reversed(libs))
[dep_libs.append(lib) for lib in libnames if lib not in libs]
libs.extend(reversed(dep_libs))
return libs

def _all_extra_objects(self):
libs = []
Expand Down
Loading