Fix Fillomino [?] region size validation (fixes #462)#697
Merged
Conversation
|
@mashinosatoshi is attempting to deploy a commit to the robx's projects Team on Vercel. A member of the Team first needs to authorize it. |
x-sheep
requested changes
Mar 25, 2026
Collaborator
x-sheep
left a comment
There was a problem hiding this comment.
Thanks for the pull request. While question marks should generally be avoided completely in finished puzzles, there's no harm in fixing the issue of course.
Contributor
Author
|
Thank you for your review. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #462, where two
?regions of the same size touching each other incorrectly passed the answer check without raising absSameNumerror in Fillomino.Root cause
When a region is composed entirely of
?markers, its logical number in the graph was evaluated as-2. During the adjacent area matching (checkSideAreaNumberSize), values<= 0are skipped to avoid false flags. As a result, identical-size?regions did not trigger the validation for "same size area sharing an edge".Fix details
Updated the graph generation logic so that it assigns the current area size (
clist.length) as the region's number when it consists exclusively of?. This makes its behavior consistent with empty cell regions, ensuring the adjacent size comparison works correctly and errors are properly flagged.A test case proving this validation fix has been added in
test/variety/fillomino_test.js.Fixes #462