Skip to content

Fix Fillomino [?] region size validation (fixes #462) #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
x-sheep merged 3 commits into from
Mar 25, 2026
Merged

Fix Fillomino [?] region size validation (fixes #462) #697

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dac9531
Fix Fillomino [?] region size validation (fixes #462)
mashinosatoshi Mar 23, 2026
79a6bd7
check format
mashinosatoshi Mar 23, 2026
61a7ff8
fix points raised in the review
mashinosatoshi Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/variety/fillomino.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,13 @@
}
component.numkind = numkind;
component.number =
numkind === 1 ? filled : numkind === 0 ? clist.length : -1;
numkind === 1
? filled === -2
? clist.length
: filled
: numkind === 0
? clist.length
: -1;
component.complete = clist.length === component.number;
component.looseborders = null;
},
Expand Down
17 changes: 17 additions & 0 deletions test/variety/fillomino_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,21 @@ describe("Variety:fillomino", function() {
center.adjacent.left.setNum(-1);
assert.equal(center.adjborder.top.qcmp, 0);
});

it("detects same size regions with ? properly", function() {
var p = new pzpr.Puzzle();
p.open("fillomino/5/1");
p.board.getc(1, 1).setNum(-2);
p.board.getc(3, 1).setNum(-2);
p.board.getb(2, 1).setQans(0);
p.board.getb(4, 1).setQans(1);
p.board.getc(5, 1).setNum(-2);
p.board.getc(7, 1).setNum(-2);
p.board.getb(6, 1).setQans(0);
p.board.getb(8, 1).setQans(1);
p.board.getc(9, 1).setNum(1);
p.board.numblkgraph.rebuild();
var check = p.check(true);
assert.equal(check[0], "bsSameNum");
});
});
Loading