Fixes #1464
Fixes #1464
Conversation
There was a problem hiding this comment.
Pull request overview
This PR applies several minor fixes across the codebase, including UI improvements for filter chips and form validation adjustments.
- Adds text truncation styling for active filter chips in the database table view
- Removes SSL certificate required validation in the Redis credentials form
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
db-table-view.component.html |
Adds CSS class to active filter chips for styling |
db-table-view.component.css |
Implements max-width and overflow rules for filter chip text labels |
redis-credentials-form.component.html |
Removes required attribute from SSL certificate textarea field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| .db-table-active-filter-chip ::ng-deep .mdc-evolution-chip__text-label { | ||
| max-width: 300px; | ||
| overflow: hidden; |
There was a problem hiding this comment.
The CSS rule sets overflow: hidden and max-width: 300px but is missing text-overflow: ellipsis to indicate to users that the text has been truncated. Without this property, the text will be abruptly cut off without any visual indication. Consider adding text-overflow: ellipsis; to show an ellipsis (...) when the text exceeds the maximum width.
| overflow: hidden; | |
| overflow: hidden; | |
| text-overflow: ellipsis; | |
| white-space: nowrap; |
|
|
||
| .db-table-active-filter-chip ::ng-deep .mdc-evolution-chip__text-label { | ||
| max-width: 300px; | ||
| overflow: hidden; |
There was a problem hiding this comment.
The CSS rule needs white-space: nowrap; in addition to overflow: hidden to prevent text wrapping and ensure proper truncation behavior. Without this property, text may wrap to multiple lines before being clipped, which defeats the purpose of the truncation.
| overflow: hidden; | |
| overflow: hidden; | |
| white-space: nowrap; |
| angulartics2On="change" | ||
| angularticsAction="Connection creds {{ connection.id ? 'edit' : 'add' }}: SSL certificate is edited" | ||
| [required]="connection.ssl" [readonly]="accessLevel === 'readonly' && connection.id" | ||
| [readonly]="accessLevel === 'readonly' && connection.id" |
There was a problem hiding this comment.
The [required] attribute has been removed from the SSL certificate textarea, but the associated error message on line 173 still checks for sslCert.errors?.required. This error message will never be displayed now. Consider removing the <mat-error> element on line 173 to keep the template clean, or clarify if SSL certificate validation will be handled elsewhere.
No description provided.