Skip to content

Fixes #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyubov-voloshko merged 3 commits into from
Dec 9, 2025
Merged

Fixes #1464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a70d4cc
table view: fix active filters max width
lyubov-voloshko Nov 27, 2025
e05f062
redis connection: remove required from ssl certificate
lyubov-voloshko Dec 9, 2025
4132ac9
Merge branch 'main' into fixes
lyubov-voloshko Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...nect-db/db-credentials-forms/redis-credentials-form/redis-credentials-form.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
data-testid="connection-ssl-certificate-textarea"
angulartics2On="change"
angularticsAction="Connection creds {{ connection.id ? 'edit' : 'add' }}: SSL certificate is edited"
[required]="connection.ssl" [readonly]="accessLevel === 'readonly' && connection.id"
[readonly]="accessLevel === 'readonly' && connection.id"
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The [required] attribute has been removed from the SSL certificate textarea, but the associated error message on line 173 still checks for sslCert.errors?.required. This error message will never be displayed now. Consider removing the <mat-error> element on line 173 to keep the template clean, or clarify if SSL certificate validation will be handled elsewhere.

Copilot uses AI. Check for mistakes.
[disabled]="submitting"
[(ngModel)]="connection.cert"
></textarea>
Expand Down
5 changes: 5 additions & 0 deletions frontend/src/app/components/dashboard/db-table-view/db-table-view.component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,11 @@
margin-bottom: 12px;
}

.db-table-active-filter-chip ::ng-deep .mdc-evolution-chip__text-label {
max-width: 300px;
overflow: hidden;
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS rule sets overflow: hidden and max-width: 300px but is missing text-overflow: ellipsis to indicate to users that the text has been truncated. Without this property, the text will be abruptly cut off without any visual indication. Consider adding text-overflow: ellipsis; to show an ellipsis (...) when the text exceeds the maximum width.

Suggested change
overflow: hidden;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS rule needs white-space: nowrap; in addition to overflow: hidden to prevent text wrapping and ensure proper truncation behavior. Without this property, text may wrap to multiple lines before being clipped, which defeats the purpose of the truncation.

Suggested change
overflow: hidden;
overflow: hidden;
white-space: nowrap;

Copilot uses AI. Check for mistakes.
}

.empty-table-message {
display: inline-block;
margin-top: 40px;
Expand Down
1 change: 1 addition & 0 deletions frontend/src/app/components/dashboard/db-table-view/db-table-view.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ <h2 class="mat-h2 table-name">{{ displayName }}</h2>

<div *ngIf="getFiltersCount(activeFilters) !== 0 && !hasSavedFilterActive" class="active-filters">
<mat-chip-row *ngFor="let activeFilter of activeFilters | keyvalue" data-hj-suppress
class="db-table-active-filter-chip"
(removed)="removeFilter.emit(activeFilter.key)">
{{ getFilter(activeFilter) }}
<button matChipRemove>
Expand Down
Loading