refactor: remove node-gyp dependency from package.json and yarn.lock #1475
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to remove the node-gyp dependency from the project's package.json and yarn.lock files. However, the removal is incomplete and introduces potential build issues.
- Removes
node-gyp: ^11.5.0from shared-code/package.json dependencies - Updates yarn.lock to remove the
node-gyp@npm:^11.5.0reference from the dependency resolution
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| shared-code/package.json | Removes node-gyp from the dependencies list, but packageExtensions still reference it for ibm_db |
| yarn.lock | Updates node-gyp resolution to only keep the "latest" variant, removing the ^11.5.0 reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "lru-cache": "^11.2.2", | ||
| "mongodb": "^6.20.0", | ||
| "mysql2": "^3.15.3", | ||
| "nanoid": "^5.1.6", |
There was a problem hiding this comment.
The node-gyp dependency was removed from the dependencies list, but it's still referenced in the packageExtensions section at lines 6-11. The packageExtensions specify that ibm_db should have node-gyp ^11.5.0 as a dependency. This creates an inconsistency where node-gyp is indirectly required but not directly available.
Since ibm_db is listed as an optional dependency (line 43) and requires node-gyp to build its native modules, this incomplete removal could cause build failures when ibm_db attempts to install. Either the node-gyp dependency should be restored, or the packageExtensions section should be updated to remove or adjust the node-gyp reference for ibm_db.
| "nanoid": "^5.1.6", | |
| "nanoid": "^5.1.6", | |
| "node-gyp": "^11.5.0", |
No description provided.