Skip to content

refactor: remove node-gyp dependency from package.json and yarn.lock #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artuomka merged 2 commits into from
Dec 16, 2025
+1 −3
Merged

refactor: remove node-gyp dependency from package.json and yarn.lock #1475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08db31f
refactor: remove node-gyp dependency from package.json and yarn.lock
Artuomka Dec 16, 2025
28402db
Merge branch 'main' into backend_unused_code
Artuomka Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion shared-code/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
"mongodb": "^6.20.0",
"mysql2": "^3.15.3",
"nanoid": "^5.1.6",
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node-gyp dependency was removed from the dependencies list, but it's still referenced in the packageExtensions section at lines 6-11. The packageExtensions specify that ibm_db should have node-gyp ^11.5.0 as a dependency. This creates an inconsistency where node-gyp is indirectly required but not directly available.

Since ibm_db is listed as an optional dependency (line 43) and requires node-gyp to build its native modules, this incomplete removal could cause build failures when ibm_db attempts to install. Either the node-gyp dependency should be restored, or the packageExtensions section should be updated to remove or adjust the node-gyp reference for ibm_db.

Suggested change
"nanoid": "^5.1.6",
"nanoid": "^5.1.6",
"node-gyp": "^11.5.0",

Copilot uses AI. Check for mistakes.
"node-gyp": "^11.5.0",
"oracledb": "^6.10.0",
"p-queue": "^9.0.0",
"pg": "^8.16.3",
Expand Down
3 changes: 1 addition & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3159,7 +3159,6 @@ __metadata:
mongodb: ^6.20.0
mysql2: ^3.15.3
nanoid: ^5.1.6
node-gyp: ^11.5.0
oracledb: ^6.10.0
p-queue: ^9.0.0
pg: ^8.16.3
Expand Down Expand Up @@ -10027,7 +10026,7 @@ __metadata:
languageName: node
linkType: hard

"node-gyp@npm:^11.5.0, node-gyp@npm:latest":
"node-gyp@npm:latest":
version: 11.5.0
resolution: "node-gyp@npm:11.5.0"
dependencies:
Expand Down
Loading