Skip to content

Lionel #PTBC2|1#39

Open
player-aaa wants to merge 5 commits intorocketacademy:mainfrom
player-aaa:master
Open

Lionel #PTBC2|1#39
player-aaa wants to merge 5 commits intorocketacademy:mainfrom
player-aaa:master

Conversation

@player-aaa
Copy link

Please fill out the survey before submitting the pull request. Thanks!

🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀

How many hours did you spend on this assignment?
80

Please fill in one error and/or error message you received while working on this assignment.
Unable to "clone" over eventlisteners to a new div element

What part of the assignment did you spend the most time on?
Creating the DOM elements

Comfort Level (1-5):
3

Completeness Level (1-5):
3

What did you think of this deliverable?
Pretty fun

Is there anything in this code that you feel pleased about?
The code is working as expected

@upieez
Copy link

upieez commented Jan 11, 2022

What went well

  • Creative use of CSS to create a card design
  • Validation for the bets which disallows users to bet an insufficient amount
  • Game works on both the desktop and mobile view

What can be improved

  • Consider updating your README.md to document what your app does (i.e images of your game, further ideas of future features, resources you have used, what features your game has, etc...)
  • Consider committing your code more frequently
  • Consider utilising other elements to make your game more appealing
  • Consider making your functions smaller and more modular

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants