Support .jsonc extension for all JSON files#1159
Merged
Dekkonot merged 18 commits intorojo-rbx:masterfrom Nov 19, 2025
Merged
Conversation
kennethloeffler
approved these changes
Nov 16, 2025
Member
kennethloeffler
left a comment
There was a problem hiding this comment.
Nice, I quite like the new helpers for meta files!
|
Looks like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1144, we swapped our parser over to JSONC for all JSON projects. However, we did not support
.jsoncas an extension for any of Rojo's files. This causes problems with linters and other niceties.This PR fixes that! It adds support for:
This turned out to be more complicated than anticipated because a lot of the support for
default.project.jsonand.meta.jsonfiles were hardcoded.To that end:
default.project.jsonand instead uses a function built intoProjectdefault.project.jsonanddefault.project.jsoncfrom_sliceand applying it, so that.meta.jsoncsupport could be done in one place