[cmake][pyroot] Fix install directory on Windows#18990
[cmake][pyroot] Fix install directory on Windows#18990bellenot wants to merge 3 commits intoroot-project:masterfrom
Conversation
Test Results 19 files 19 suites 3d 6h 50m 31s ⏱️ Results for commit fd06b8f. ♻️ This comment has been updated with latest results. |
|
Could a reference to this commit be added in the commit message and PR comment so that we remember what happened? 9bb2f50 |
dpiparo
left a comment
dpiparo
left a comment
There was a problem hiding this comment.
Let's wait and see whether a comprehensive solution (mac and win) can be found?
|
We have zero test coverage for the install tree, so I guess any changes affect it will have these incremental fixups :( But good that you fixed it for Windows now! I have not seen the problem on macOS though, do you have an example error message and build log? I think eventually we really need some post install tests, like suggested by Stephan: Just checking if some basic ROOT macro and |
|
You really have a point. Something relatively inexpensive could be done for PRs too... |
Fix wrong install directory introduced by commit root-project@9bb2f50 This made CPack failing with the following error message: ``` CMake Error at C:/ROOT-CI/build/bindings/pyroot/pythonizations/cmake\_install.cmake:75 (file): file cannot create directory: C:/Program Files (x86)/ROOT/bin/ROOT. ```
3 participants
No description provided.