[roottest] root/tree, part 4#19525
Merged
linev merged 8 commits intoroot-project:masterfrom Aug 20, 2025
Merged
Conversation
Test Results 21 files 21 suites 3d 13h 38m 42s ⏱️ For more details on these failures, see this check. Results for commit d9f688a. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Aug 18, 2025
pcanal
approved these changes
Aug 18, 2025
Member
pcanal
left a comment
pcanal
left a comment
There was a problem hiding this comment.
LGTM. Minor comment: ClassDefOverride is now the prefered ClassDef as it allows warning when virtual function signature changes.
pcanal
reviewed
Aug 18, 2025
pcanal
reviewed
Aug 18, 2025
Was not used before Run provided methods Use compression 0 to avoid difference on different platforms
Add ref file, set fixed seed for gRandom
Instead DEPENDS and PRE_CMD use separate tests and fixtures to configure test dependencies
Remove full macro path Co-authored-by: Philippe Canal <pcanal@fnal.gov>
Remove full macro path Co-authored-by: Philippe Canal <pcanal@fnal.gov>
Member
Author
|
Failures not related to PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #