Skip to content

[roottest] root/tree, part 5#19526

Merged
linev merged 9 commits intoroot-project:masterfrom
linev:roottest_tree_5
Aug 20, 2025
Merged

[roottest] root/tree, part 5#19526
linev merged 9 commits intoroot-project:masterfrom
linev:roottest_tree_5

Conversation

@linev
Copy link
Member

@linev linev commented Aug 4, 2025

This Pull request:

Changes or fixes:

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #

linev added 9 commits August 4, 2025 21:26
For reflex part create normal dictionary with library
Load necessary reflex or cint library via ROOTEXE_OPTS,
otherwise provided classes not available in named macros
Seems to be on Windows 32bit test works exactly the same
If fails while branch.root file left open.
It works correctly on other platforms
ABC used in some Windows headers as type and conflict with ABC type name used in the original test
@linev linev requested a review from pcanal August 4, 2025 19:31
@linev linev self-assigned this Aug 4, 2025
@linev linev requested review from bellenot and dpiparo as code owners August 4, 2025 19:31
@github-actions
Copy link

github-actions bot commented Aug 5, 2025

Test Results

    21 files      21 suites   3d 5h 55m 37s ⏱️
 3 280 tests  3 280 ✅ 0 💤 0 ❌
67 151 runs  67 151 ✅ 0 💤 0 ❌

Results for commit 1665890.

♻️ This comment has been updated with latest results.

Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@linev linev merged commit 486daf9 into root-project:master Aug 20, 2025
66 of 70 checks passed
@linev linev deleted the roottest_tree_5 branch August 20, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants