[cmake] Disable failing test#20142
Conversation
`TestSofieModels` is failing on alma8, alma10, ubuntu2204, and ubuntu2404
|
Can we be maybe more specific here, i.e. mention that the tests fail with the new PyTorch 2.9.0? Also, is should be possible to disable the tests conditional on the Python package version (see our FIND_PYTHON_PACKAGE macro). We should also open an issue to remind us that PyTorch 2.9.0 support needs to be taken care of. |
I didn't know it was specific to PyTorch 2.9.0... And I'll check how to disable it conditionally (just trying to do my shifter job here...) |
|
@guitargeek the PR has been updated and a GH issue created (#20145) |
|
@guitargeek it doesn't work... |
|
It looks like the check for Yes, I'm sure the problem is PyTorch 2.9.0 because the failures appeared in the CI once this version got released a few days ago: It would just be very nice to still run the test on platforms with older pytorch versions, so we don't completely lose test coverage on Linux for this test |
|
@guitargeek my bad, I used the wrong logic (thanks @linev for letting me know). Should be fine now |
guitargeek
left a comment
There was a problem hiding this comment.
Thank you very much for this! Let's squash the commits on merging.
Test Results 21 files 21 suites 3d 12h 9m 44s ⏱️ Results for commit 34e2780. |
TestSofieModelsis failing on alma8, alma10, ubuntu2204, and ubuntu2404