Skip to content

[cmake] Disable failing test#20142

Merged
guitargeek merged 4 commits intoroot-project:masterfrom
bellenot:disable-testsofiemodels-master
Oct 20, 2025
Merged

[cmake] Disable failing test#20142
guitargeek merged 4 commits intoroot-project:masterfrom
bellenot:disable-testsofiemodels-master

Conversation

@bellenot
Copy link
Copy Markdown
Member

TestSofieModels is failing on alma8, alma10, ubuntu2204, and ubuntu2404

`TestSofieModels` is failing on alma8, alma10, ubuntu2204, and ubuntu2404
@bellenot bellenot self-assigned this Oct 20, 2025
@bellenot bellenot requested a review from vepadulano October 20, 2025 07:48
@guitargeek
Copy link
Copy Markdown
Contributor

Can we be maybe more specific here, i.e. mention that the tests fail with the new PyTorch 2.9.0? Also, is should be possible to disable the tests conditional on the Python package version (see our FIND_PYTHON_PACKAGE macro).

We should also open an issue to remind us that PyTorch 2.9.0 support needs to be taken care of.

@bellenot
Copy link
Copy Markdown
Member Author

Can we be maybe more specific here, i.e. mention that the tests fail with the new PyTorch 2.9.0? Also, is should be possible to disable the tests conditional on the Python package version (see our FIND_PYTHON_PACKAGE macro).

We should also open an issue to remind us that PyTorch 2.9.0 support needs to be taken care of.

I didn't know it was specific to PyTorch 2.9.0... And I'll check how to disable it conditionally (just trying to do my shifter job here...)

@bellenot
Copy link
Copy Markdown
Member Author

@guitargeek the PR has been updated and a GH issue created (#20145)

@bellenot
Copy link
Copy Markdown
Member Author

@guitargeek it doesn't work...

@guitargeek
Copy link
Copy Markdown
Contributor

It looks like the check for pytorch 2.9.0 that you implemented doesn't work yet 🙁

Yes, I'm sure the problem is PyTorch 2.9.0 because the failures appeared in the CI once this version got released a few days ago:
https://pypi.org/project/torch/#history

It would just be very nice to still run the test on platforms with older pytorch versions, so we don't completely lose test coverage on Linux for this test

@bellenot
Copy link
Copy Markdown
Member Author

bellenot commented Oct 20, 2025

@guitargeek my bad, I used the wrong logic (thanks @linev for letting me know). Should be fine now

@bellenot bellenot requested a review from guitargeek October 20, 2025 13:53
Copy link
Copy Markdown
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this! Let's squash the commits on merging.

@github-actions
Copy link
Copy Markdown

Test Results

    21 files      21 suites   3d 12h 9m 44s ⏱️
 3 692 tests  3 692 ✅ 0 💤 0 ❌
75 602 runs  75 602 ✅ 0 💤 0 ❌

Results for commit 34e2780.

@guitargeek guitargeek merged commit 5f3a91f into root-project:master Oct 20, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants