Skip to content

[cmake] Disable failing test #20142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guitargeek merged 4 commits into from
Oct 20, 2025
Merged

[cmake] Disable failing test #20142

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58a68ba
[cmake] Disable failing test
bellenot Oct 20, 2025
9437b96
Disable TestSofieModels only if PyTorch >= 2.9.0
bellenot Oct 20, 2025
b03d013
[cmake] Add debug print statement
bellenot Oct 20, 2025
34e2780
[cmake] Use correct logic (thanks Sergey)
bellenot Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions tmva/sofie/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,24 @@ if (ROOT_TORCH_FOUND)
configure_file(RecurrentModelGenerator.py RecurrentModelGenerator.py COPYONLY)

if (BLAS_FOUND)
ROOT_ADD_GTEST(TestSofieModels TestSofieModels.cxx
LIBRARIES
ROOTTMVASofie
ROOTTMVASofieParser
BLAS::BLAS
INCLUDE_DIRS
${CMAKE_CURRENT_BINARY_DIR}
)
execute_process(COMMAND "${Python3_EXECUTABLE}" "-c"
"import torch; print(getattr(torch, '__version__', 'unknown'))"
RESULT_VARIABLE status
OUTPUT_VARIABLE module_version
OUTPUT_STRIP_TRAILING_WHITESPACE
ERROR_QUIET)
if(${status} EQUAL 0 AND ${module_version} VERSION_LESS 2.9.0)
# Disable TestSofieModels which is failing on alma8, alma10, ubuntu2204, and ubuntu2404
# with PyTorch 2.9.0
ROOT_ADD_GTEST(TestSofieModels TestSofieModels.cxx
LIBRARIES
ROOTTMVASofie
ROOTTMVASofieParser
BLAS::BLAS
INCLUDE_DIRS
${CMAKE_CURRENT_BINARY_DIR}
)
endif()
endif()
endif()

Expand Down
Loading