[graph2d] avoid float arithmetic uncertainties in exclusion plots#20144
Merged
linev merged 2 commits intoroot-project:masterfrom Oct 23, 2025
Merged
[graph2d] avoid float arithmetic uncertainties in exclusion plots#20144linev merged 2 commits intoroot-project:masterfrom
linev merged 2 commits intoroot-project:masterfrom
Conversation
To avoid rounding effects in TGraph exclusion points optimization, use small epsilon in values comparasion.
Test Results 14 files 14 suites 2d 4h 45m 24s ⏱️ For more details on these failures, see this check. Results for commit 20003a3. ♻️ This comment has been updated with latest results. |
couet
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
1e-12epsilon in comparison of float values when optimize exclusion area of TGraph.Allows to create reproducible SVG/PS output on different platforms.
Also use
TMath::Pi()for Pi constants