[tmva][sofie] Fix testSofieModels for new torch version#20149
Merged
lmoneta merged 2 commits intoroot-project:masterfrom Oct 20, 2025
Merged
[tmva][sofie] Fix testSofieModels for new torch version#20149lmoneta merged 2 commits intoroot-project:masterfrom
lmoneta merged 2 commits intoroot-project:masterfrom
Conversation
sanjibansg
approved these changes
Oct 20, 2025
Collaborator
sanjibansg
left a comment
sanjibansg
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for fixing this issue!
Contributor
|
Hi! Could you add the revert of commit 5f3a91f here? Thanks! |
New torch versions comes with a new export mode to ONNX. One needs to specify forst to have a single onnx file with the weights (external_data=False) and then in some case (new export mode, which is with dynamo=True) does not fork for batchNorm and recurrent network. Disable it for these cases.
This reverts commit 5f3a91f.
lmoneta
force-pushed
the
tmva_sofie_fix_testsofiemodels_fromtorch
branch
from
5cdb6ed to
de83a5b
Compare
Collaborator
|
Fixes #20145 |
1 task
Member
|
Are we sure this is fixing all platforms? I can see both Mac runners failing in this PR https://github.com/root-project/root/actions/runs/18656813948/job/53187961355 https://github.com/root-project/root/actions/runs/18656813948/job/53187961360 |
Member
|
FWIW the failure (that was already visible in this PR!) is So probably this PR requires the new PyTorch version. I'm not sure that this is what we want... |
This was referenced Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New torch versions comes with a new export mode to ONNX. One needs to specify first to have a single onnx file with the weights (external_data=False) and then in some case (new export mode, which is with dynamo=True) does not work for batchNorm and recurrent network. Disable it for these cases.
This PR should fix the test TestSofieModels