Skip to content

Don't issue deprecation warnings in rootcling v6.38#20289

Closed
hageboeck wants to merge 3 commits intoroot-project:v6-38-00-patchesfrom
hageboeck:no_deprecation_cling_v6.38
Closed

Don't issue deprecation warnings in rootcling v6.38#20289
hageboeck wants to merge 3 commits intoroot-project:v6-38-00-patchesfrom
hageboeck:no_deprecation_cling_v6.38

Conversation

@hageboeck
Copy link
Member

@hageboeck hageboeck commented Nov 5, 2025

This Pull request:

Changes or fixes:

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #

@hageboeck
[core] Don't issue deprecation warnings in rootcling.
90099a5 
When functions/classes get deprecated, rootcling should still
successfully generate the dictionaries. Therefore, the R__DEPRECATED
macros will be defined to empty in rootcling.
@hageboeck
Revert "[math] Removed deprecated routine"
3080eb1 
This reverts commit 4f607d7.
@hageboeck
Revert "[RDF] Remote deprecated snapshot method"
c7f4d37 
This reverts commit f7d3429.
@hageboeck hageboeck self-assigned this Nov 5, 2025
@hageboeck hageboeck changed the title No deprecation cling v6.38 Don't issue deprecation warnings in rootcling v6.38 Nov 5, 2025
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Test Results

    22 files      22 suites   3d 20h 58m 9s ⏱️
 3 704 tests  3 704 ✅ 0 💤 0 ❌
79 555 runs  79 555 ✅ 0 💤 0 ❌

Results for commit c7f4d37.

hahnjo
hahnjo requested changes Nov 5, 2025
View reviewed changes
Copy link
Member

@hahnjo hahnjo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is wrong. The real problem is that graf3d/gl/inc/TGLWSIncludes.h has

#if ROOT_VERSION_CODE >= ROOT_VERSION(6, 38, 00)

That is now the case for v6-38-00-patches (not yet, it's still 6.37.99 for the moment). The correct condition (inversion from RConfig.hxx) would be

#if ROOT_VERSION_CODE > ROOT_VERSION(6, 39, 0)

@hageboeck
Copy link
Member Author

hageboeck commented Nov 5, 2025

I think this is wrong.

That's why there is #20290, because I also said that it shouldn't have to do with rootcling, and couldn't reproduce it locally.

@hageboeck hageboeck closed this Nov 5, 2025
@hageboeck hageboeck deleted the no_deprecation_cling_v6.38 branch November 5, 2025 13:45
@hahnjo hahnjo mentioned this pull request Nov 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hahnjo hahnjo hahnjo requested changes

@martamaja10 martamaja10 Awaiting requested review from martamaja10 martamaja10 will be requested when the pull request is marked ready for review martamaja10 is a code owner

@vepadulano vepadulano Awaiting requested review from vepadulano vepadulano will be requested when the pull request is marked ready for review vepadulano is a code owner

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo will be requested when the pull request is marked ready for review dpiparo is a code owner

@pcanal pcanal Awaiting requested review from pcanal pcanal will be requested when the pull request is marked ready for review pcanal is a code owner

Assignees

@hageboeck hageboeck

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hageboeck @hahnjo