[v6.38] Fix an upcoming error for v6.38#20290
Merged
hageboeck merged 1 commit intoroot-project:v6-38-00-patchesfrom Nov 6, 2025
Merged
[v6.38] Fix an upcoming error for v6.38#20290hageboeck merged 1 commit intoroot-project:v6-38-00-patchesfrom
hageboeck merged 1 commit intoroot-project:v6-38-00-patchesfrom
Conversation
Test Results 22 files 22 suites 4d 3h 40m 28s ⏱️ Results for commit a0e4ba5. ♻️ This comment has been updated with latest results. |
Member
|
Maybe it would be better to force-push the branch, actually removing the two commits? |
hageboeck
force-pushed
the
revert_deprecated_functions_v6.38
branch
from
9e57ff2 to
3d82edf
Compare
Member
Author
I would like to do that, but I will confirm with Danilo once he's back if it's OK. |
2 tasks
hahnjo
reviewed
Nov 5, 2025
dpiparo
force-pushed
the
v6-38-00-patches
branch
from
f7d3429 to
025a098
Compare
hageboeck
force-pushed
the
revert_deprecated_functions_v6.38
branch
from
3d82edf to
dfb4a95
Compare
hageboeck
changed the title
The TGLWSIncludes.h header is being removed from the public interface in v6.40. Due to using >= 6.38, it was causing a compiler error already in v6.38, where it was supposed to raise only a warning. Here, the version number is corrected, and the error message is written for users instead of ROOT developers. On Windows, the unsupported #warning is suppressed.
hageboeck
force-pushed
the
revert_deprecated_functions_v6.38
branch
from
dfb4a95 to
a0e4ba5
Compare
hahnjo
approved these changes
Nov 6, 2025
hageboeck
merged commit a3828be
into
root-project:v6-38-00-patches
49 of 50 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TGLWSIncludes.h header is being removed from the public interface
in v6.40. Due to using >= 6.38, it will cause a compiler error already
when the version number is incremented to 6.38, where it was supposed to raise only a warning.
Here, the version number is corrected, and the error message is written for users instead of ROOT developers.
On Windows, the unsupported
#warningis suppressed.