Conversation
| 'exclude_factories' => 'false', | ||
| 'ignore_model_sub_dir' => 'false', | ||
| 'skip_on_db_migrate' => 'false', | ||
| 'format_bare' => 'true', |
There was a problem hiding this comment.
format_bare was the only config missing in .annotaterb.yml, so I added manually
| @@ -0,0 +1,59 @@ | |||
| --- | |||
There was a problem hiding this comment.
autogenerated file
There was a problem hiding this comment.
autogenerated but adjusted given the configs in lib/tasks/auto_annotate_models.rake right?
This reverts commit f02de3a.
There was a problem hiding this comment.
Did you follow the steps in https://guides.rubyonrails.org/upgrading_ruby_on_rails.html ?
I see some steps missing, like upgrading the Rails JS packages, and running the app "update task"
Ideally, any default that we have (and did not modify on purpose) should be updated with any new Rails default (e.g. this happens a lot in config/environments/* files, initializers, etc). So we need to do like a merge of these files as explained in the link above
|
|
||
| puts "\n== Everything is good to go! ==" | ||
|
|
||
| unless ARGV.include?('--skip-server') |
There was a problem hiding this comment.
not sure if this is necessary 🤔
@santib thoughts ?
There was a problem hiding this comment.
if this is Rails default then I'd leave it. I guess they extended the setup script so that it also starts the server by default which sounds reasonable to me
bin/setup
Outdated
| # system "ln -nfs #{APP_ROOT} ~/.puma-dev/#{APP_NAME}" | ||
| # system "curl -Is https://#{APP_NAME}.test/up | head -n 1" |
There was a problem hiding this comment.
these two lines should be removed as well
5 participants
Description:
Rails 8 upgrade.
devise_auth_tokendoes not have a release with Rails 8 support yet.annotategem is not compatible with rails 8, and is not maintained. Replaced it withannotaterbNotes:
Tasks:
Risk:
Preview: