-
Notifications
You must be signed in to change notification settings - Fork 138
Rails 8 upgrade #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rails 8 upgrade #991
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
994a220
gemfile
santir489 658cf6d
upgrade rails 8
santir489 c25552f
annotate clean up
santir489 ac95073
fix linters
santir489 f02de3a
annotate routes
santir489 094efbb
Revert "annotate routes"
santir489 8859c98
add params.expect
santir489 b619a8b
update CI to use annotaterb
santir489 d8e46d9
update configs
santir489 7e417d2
update task
santir489 4fcb4be
update readme
santir489 8f9c432
bundle update devise_token_auth
santir489 1bbe933
fix comments
santir489 db1f9cb
address comments
santir489 1474e9b
add frozen_string_literal back
santir489 8c4576f
Update bin/setup
santib File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| --- | ||
| :position: before | ||
| :position_in_additional_file_patterns: before | ||
| :position_in_class: before | ||
| :position_in_factory: before | ||
| :position_in_fixture: before | ||
| :position_in_routes: before | ||
| :position_in_serializer: before | ||
| :position_in_test: before | ||
| :classified_sort: true | ||
| :exclude_controllers: true | ||
| :exclude_factories: false | ||
| :exclude_fixtures: false | ||
| :exclude_helpers: true | ||
| :exclude_scaffolds: true | ||
| :exclude_serializers: false | ||
| :exclude_sti_subclasses: false | ||
| :exclude_tests: false | ||
| :force: false | ||
| :format_bare: true | ||
| :format_markdown: false | ||
| :format_rdoc: false | ||
| :format_yard: false | ||
| :frozen: false | ||
| :ignore_model_sub_dir: false | ||
| :ignore_unknown_models: false | ||
| :include_version: false | ||
| :show_check_constraints: false | ||
| :show_complete_foreign_keys: false | ||
| :show_foreign_keys: true | ||
| :show_indexes: true | ||
| :simple_indexes: false | ||
| :sort: false | ||
| :timestamp: false | ||
| :trace: false | ||
| :with_comment: true | ||
| :with_column_comments: true | ||
| :with_table_comments: true | ||
| :active_admin: false | ||
| :command: | ||
| :debug: false | ||
| :hide_default_column_types: '' | ||
| :hide_limit_column_types: '' | ||
| :ignore_columns: | ||
| :ignore_routes: | ||
| :models: true | ||
| :routes: false | ||
| :skip_on_db_migrate: false | ||
| :target_action: :do_annotations | ||
| :wrapper: | ||
| :wrapper_close: | ||
| :wrapper_open: | ||
| :classes_default_to_s: [] | ||
| :additional_file_patterns: [] | ||
| :model_dir: | ||
| - app/models | ||
| :require: [] | ||
| :root_dir: | ||
| - '' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| # This rake task was added by annotate_rb gem. | ||
|
|
||
| # Can set `ANNOTATERB_SKIP_ON_DB_TASKS` to be anything to skip this | ||
| if Rails.env.development? && ENV['ANNOTATERB_SKIP_ON_DB_TASKS'].nil? | ||
| require 'annotate_rb' | ||
|
|
||
| AnnotateRb::Core.load_rake_tasks | ||
| end |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autogenerated file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autogenerated but adjusted given the configs in
lib/tasks/auto_annotate_models.rakeright?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct!