-
Notifications
You must be signed in to change notification settings - Fork 3
Review coverage dashboard #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b799f33 to
839c1b6
Compare
santib
reviewed
May 26, 2025
| @@ -0,0 +1,7 @@ | |||
| module PullRequests | |||
| class ReviewCoveragePrsRepositoryController < PullRequestsController | |||
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a fan of using inheritance for controllers but ok
santib
reviewed
May 26, 2025
santib
reviewed
May 26, 2025
santib
reviewed
May 26, 2025
santib
reviewed
May 26, 2025
santib
reviewed
May 26, 2025
spec/services/builders/distribution/pull_requests/review_coverage_repository_spec.rb
Outdated
Show resolved
Hide resolved
santib
approved these changes
May 26, 2025
Member
santib
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM left some small comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Review Coverage Metric to Dashboard
This PR introduces a new metric to the development dashboard: Review Coverage. This feature follows the existing pattern and architecture used for other metrics in the system (review turnaround, merge time, pull request size).
Changes include:
The implementation leverages the existing metrics infrastructure, maintaining consistency in how metrics are collected, calculated, and displayed throughout the application.