Skip to content

Conversation

@gonzaM
Copy link
Contributor

@gonzaM gonzaM commented May 21, 2025

Add Review Coverage Metric to Dashboard

This PR introduces a new metric to the development dashboard: Review Coverage. This feature follows the existing pattern and architecture used for other metrics in the system (review turnaround, merge time, pull request size).

Changes include:

  • Added Review Coverage metric to repository dashboard
  • Created review coverage controllers, services, and views following the same patterns used by existing metrics
  • Implemented percentage interval resolver for displaying coverage data in appropriate ranges
  • Added repository distribution visualization for the new metric
  • Extended modal helpers and routes configuration to support the new metric details view
  • Built repository-specific PR list view for detailed analysis

The implementation leverages the existing metrics infrastructure, maintaining consistency in how metrics are collected, calculated, and displayed throughout the application.

Screenshot 2025-05-21 at 6 31 25 PM
Screenshot 2025-05-21 at 6 31 35 PM

@gonzaM gonzaM marked this pull request as ready for review May 22, 2025 13:54
@gonzaM gonzaM requested a review from a team as a code owner May 22, 2025 13:54
@gonzaM gonzaM requested review from rodrieiz, santib and sebastiancaraballo and removed request for a team and sebastiancaraballo May 22, 2025 13:54
@gonzaM gonzaM force-pushed the review_coverage_dashboard branch from b799f33 to 839c1b6 Compare May 23, 2025 20:10
@@ -0,0 +1,7 @@
module PullRequests
class ReviewCoveragePrsRepositoryController < PullRequestsController
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a fan of using inheritance for controllers but ok

Copy link
Member

@santib santib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM left some small comments

@gonzaM gonzaM merged commit eafc53a into feature/review_coverage May 27, 2025
2 checks passed
@gonzaM gonzaM deleted the review_coverage_dashboard branch May 27, 2025 17:37
@gonzaM gonzaM mentioned this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants