Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ros2-master #424 +/- ##
============================================
Coverage 78.38% 78.38%
============================================
Files 30 30
Lines 1888 1888
Branches 114 114
============================================
Hits 1480 1480
Misses 338 338
Partials 70 70
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
saikishor
previously approved these changes
Jul 1, 2025
xguay
reviewed
Jul 1, 2025
xguay
left a comment
There was a problem hiding this comment.
To make this workflow more uniform and robust to copy into other repos I'd like to suggest adding the following file formats to the list.
- .jpg
- .jpeg
- .png
- .svg
- .yml
- .bib maybe
Member
Author
You mean for the path filters? Could make sense. problem with the yml files is that the github workflows also have the same ending. I can have a look if one can exclude the .github folder but include other yaml files. |
mergify Bot
pushed a commit
that referenced
this pull request
Jul 3, 2025
(cherry picked from commit 8462152) # Conflicts: # doc/migration.rst # doc/release_notes.rst
mergify Bot
pushed a commit
that referenced
this pull request
Jul 3, 2025
(cherry picked from commit 8462152) # Conflicts: # doc/migration.rst
christophfroehlich
pushed a commit
that referenced
this pull request
Jul 3, 2025
This was referenced Jul 3, 2025
This was referenced Jul 3, 2025
christophfroehlich
pushed a commit
that referenced
this pull request
Jul 3, 2025
This was referenced Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ros-controls/control.ros.org#470