-
Notifications
You must be signed in to change notification settings - Fork 364
Cleanup deprecations #2589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Cleanup deprecations #2589
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2589 +/- ##
==========================================
+ Coverage 89.45% 89.54% +0.08%
==========================================
Files 148 148
Lines 16719 16693 -26
Branches 1406 1406
==========================================
- Hits 14956 14947 -9
+ Misses 1220 1202 -18
- Partials 543 544 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. Just few nitpicks
controller_interface/test/test_semantic_component_command_interface.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Sai Kishor Kothakota <[email protected]>
This pull request is in conflict. Could you fix it @christophfroehlich? |
Needs ros-controls/ros2_controllers#1936 to be merged first