Skip to content

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Sep 29, 2025

Needs ros-controls/ros2_controllers#1936 to be merged first

Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.54%. Comparing base (6077af4) to head (c129b77).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2589      +/-   ##
==========================================
+ Coverage   89.45%   89.54%   +0.08%     
==========================================
  Files         148      148              
  Lines       16719    16693      -26     
  Branches     1406     1406              
==========================================
- Hits        14956    14947       -9     
+ Misses       1220     1202      -18     
- Partials      543      544       +1     
Flag Coverage Δ
unittests 89.54% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...roller_interface/test/test_force_torque_sensor.cpp 100.00% <100.00%> (ø)
controller_interface/test/test_gps_sensor.cpp 100.00% <ø> (ø)
controller_interface/test/test_imu_sensor.cpp 100.00% <100.00%> (ø)
controller_interface/test/test_led_rgb_device.cpp 100.00% <100.00%> (ø)
controller_interface/test/test_pose_sensor.cpp 100.00% <100.00%> (ø)
...test/test_semantic_component_command_interface.cpp 100.00% <100.00%> (ø)
...terface/test/test_semantic_component_interface.cpp 100.00% <100.00%> (ø)
...re_interface/include/hardware_interface/handle.hpp 87.39% <ø> (ø)
.../include/hardware_interface/hardware_component.hpp 100.00% <ø> (ø)
...ardware_interface/hardware_component_interface.hpp 87.50% <100.00%> (-0.11%) ⬇️
... and 5 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich marked this pull request as ready for review October 1, 2025 22:04
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Just few nitpicks

Co-authored-by: Sai Kishor Kothakota <[email protected]>
@christophfroehlich christophfroehlich moved this from Kilted to ROS-L in Roadmap / Features Oct 2, 2025
Copy link
Contributor

mergify bot commented Oct 3, 2025

This pull request is in conflict. Could you fix it @christophfroehlich?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check-prerelease-downstream Runs the pre-release workflow with 1st level downstream dependencies
Projects
Status: ROS-L
Development

Successfully merging this pull request may close these issues.

2 participants