Integrate pal_statistics for introspecting the ros2_control_demos#654
Integrate pal_statistics for introspecting the ros2_control_demos#654
Conversation
github-actions
bot
requested review from
DasRoteSkelett,
bmagyar,
christophfroehlich,
mamueluth,
moriarty,
peterdavidfagan and
rosterloh
|
I'll set it to draft until a valid version is in the ros2_control repo. |
Sure. Thanks |
saikishor
force-pushed
the
integrate/pal_statistics
branch
from
3646e22 to
f82fc37
Compare
github-actions
bot
requested review from
VX792,
arne48,
destogl,
livanov93 and
qiayuanl
|
|
||
| for (size_t i = 0; i < reference_interface_names_.size(); i++) | ||
| { | ||
| REGISTER_ROS2_CONTROL_INTROSPECTION(reference_interface_names_[i], &reference_interfaces_[i]); |
There was a problem hiding this comment.
aren't reference interfaces exported by default?
There was a problem hiding this comment.
Yes yes, they are.
I added to just show how to introspect internal variables. I didn't know what else to register in this controller
There was a problem hiding this comment.
I see. I had a look now and don't find any other more useful variables to introspect in this repository. maybe we should have a look in ros2_controllers and register more variables to pal_statistics, currently most of the controllers have their own publisher with a custom status message type. not sure what is the best way in the controllers for doing so
There was a problem hiding this comment.
I would say yes, it is better to register some variables in the controllers
|
@saikishor how do we proceed here? |
I would say let's merge it at least it shows how to introspect internal variables |
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Then we need some documentation (in the code, in the rst) ;)
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
2 participants
Needs: ros-controls/ros2_control#1897