Skip to content

Conversation

@Karsten1987
Copy link
Contributor

fixes #70 (comment)

The launch file got also enhanced to load and start the joint state controller directly. Starting a Joint State Publisher doesn't make much sense in my opinion if you want to load the joint state controller at the same time.

Signed-off-by: Karsten Knese <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2021

Codecov Report

Merging #89 (13214ee) into master (1e14150) will not change coverage.
The diff coverage is n/a.

❗ Current head 13214ee differs from pull request most recent head 5d2a796. Consider uploading reports for the commit 5d2a796 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #89    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files           9       3     -6     
  Lines         849     283   -566     
=======================================
+ Misses        849     283   -566     
Flag Coverage Δ
unittests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ros2_control_demo_hardware/src/diffbot_system.cpp
...demo_hardware/src/rrbot_system_multi_interface.cpp
...l_demo_hardware/src/rrbot_system_position_only.cpp
...demo_hardware/src/rrbot_system_multi_interface.cpp
...l_demo_hardware/src/rrbot_system_position_only.cpp
...l_demo_hardware/src/rrbot_system_position_only.cpp
...demo_hardware/src/rrbot_system_multi_interface.cpp
.../ros2_control_demo_hardware/src/diffbot_system.cpp
.../ros2_control_demo_hardware/src/diffbot_system.cpp
...l_demo_hardware/src/rrbot_system_position_only.cpp 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e14150...5d2a796. Read the comment docs.

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the cpplint warnings + ran precommit

@bmagyar bmagyar merged commit 4cb4898 into master May 1, 2021
@bmagyar bmagyar mentioned this pull request May 1, 2021
@destogl destogl deleted the kk/diff_drive_correction branch July 6, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants