og fix of linting typecast error

arthurlovekin · arthurlovekin · commit 794b77c14c10 · 2025-01-15T13:02:42.000-08:00
diff --git a/diff_drive_controller/src/diff_drive_controller.cpp b/diff_drive_controller/src/diff_drive_controller.cpp
@@ -705,9 +705,8 @@ controller_interface::CallbackReturn DiffDriveController::configure_side(
 
 bool DiffDriveController::on_set_chained_mode(bool chained_mode)
 {
-  // Always accept switch to/from chained mode
-  (void)chained_mode;
-  return true;
+  // Always accept switch to/from chained mode (without linting type-cast error)
+  return true || chained_mode;
 }
 
 std::vector<hardware_interface::CommandInterface>

Original file line number	Diff line number	Diff line change
`@@ -705,9 +705,8 @@ controller_interface::CallbackReturn DiffDriveController::configure_side(`
`705`	`705`
`706`	`706`	`bool DiffDriveController::on_set_chained_mode(bool chained_mode)`
`707`	`707`	`{`
`708`		`- // Always accept switch to/from chained mode`
`709`		`- (void)chained_mode;`
`710`		`- return true;`
	`708`	`+ // Always accept switch to/from chained mode (without linting type-cast error)`
	`709`	`+ return true \|\| chained_mode;`
`711`	`710`	`}`
`712`	`711`
`713`	`712`	`std::vector<hardware_interface::CommandInterface>`