Skip to content

Add Mecanum Drive Controller (backport #512, #1444, #1547)#1376

Merged
christophfroehlich merged 10 commits intohumblefrom
mergify/bp/humble/pr-512
Mar 11, 2025
Merged

Add Mecanum Drive Controller (backport #512, #1444, #1547)#1376
christophfroehlich merged 10 commits intohumblefrom
mergify/bp/humble/pr-512

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 19, 2024

Depends on ros-controls/control_msgs#79


This is an automatic backport of pull request #512 done by Mergify.

(cherry picked from commit 79358e3)
@soham2560
Copy link

are there any estimates on when this might be done?

or on how much work there is, I can try to pick it up if I get the time and if no-one else is working on it

@bmagyar
Copy link
Member

bmagyar commented Mar 6, 2025

@soham2560 yes please! Create PR(s) targeting this backport branch please.

There were a few API changes in controller interface between humble and Jazzy. Those definitely need fixing for the build to pass.

@christophfroehlich
Copy link
Member

you can always compile the rolling version of the ros2_control stack on humble, see "development version" on https://control.ros.org/humble/doc/getting_started/getting_started.html#building-from-source

christophfroehlich and others added 3 commits March 7, 2025 20:03
Co-authored-by: Soham Patil <sohampatil45939@gmail.com>
Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
@christophfroehlich christophfroehlich marked this pull request as ready for review March 8, 2025 14:00
@christophfroehlich christophfroehlich changed the title Add Mecanum Drive Controller (backport #512) Add Mecanum Drive Controller (backport #512, #1444, #1547) Mar 8, 2025
@soham2560
Copy link

@bmagyar can you have a look at this?

@christophfroehlich christophfroehlich merged commit f8292bd into humble Mar 11, 2025
13 of 14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-512 branch March 11, 2025 07:15
@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 68.09584% with 253 lines in your changes missing coverage. Please review.

Project coverage is 67.03%. Comparing base (5de2dfa) to head (d7c7fbb).
Report is 3 commits behind head on humble.

Files with missing lines Patch % Lines
..._controller/test/test_mecanum_drive_controller.cpp 48.35% 0 Missing and 157 partials ⚠️
..._drive_controller/src/mecanum_drive_controller.cpp 84.81% 30 Missing and 11 partials ⚠️
.../test/test_mecanum_drive_controller_preceeding.cpp 42.55% 0 Missing and 27 partials ⚠️
..._controller/test/test_mecanum_drive_controller.hpp 80.41% 9 Missing and 10 partials ⚠️
mecanum_drive_controller/src/odometry.cpp 86.53% 6 Missing and 1 partial ⚠️
...roller/test/test_load_mecanum_drive_controller.cpp 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1376      +/-   ##
==========================================
+ Coverage   66.93%   67.03%   +0.09%     
==========================================
  Files         115      122       +7     
  Lines       13575    14368     +793     
  Branches     8402     8877     +475     
==========================================
+ Hits         9087     9632     +545     
- Misses       1423     1460      +37     
- Partials     3065     3276     +211     
Flag Coverage Δ
unittests 67.03% <68.09%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ller/include/mecanum_drive_controller/odometry.hpp 100.00% <100.00%> (ø)
...roller/test/test_load_mecanum_drive_controller.cpp 87.50% <87.50%> (ø)
mecanum_drive_controller/src/odometry.cpp 86.53% <86.53%> (ø)
..._controller/test/test_mecanum_drive_controller.hpp 80.41% <80.41%> (ø)
.../test/test_mecanum_drive_controller_preceeding.cpp 42.55% <42.55%> (ø)
..._drive_controller/src/mecanum_drive_controller.cpp 84.81% <84.81%> (ø)
..._controller/test/test_mecanum_drive_controller.cpp 48.35% <48.35%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants