[CI] Add clang job and setup concurrency#1407
Merged
christophfroehlich merged 17 commits intomasterfrom Dec 9, 2024
Merged
Conversation
ddc472b to
35abc6c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1407 +/- ##
==========================================
- Coverage 83.60% 83.59% -0.01%
==========================================
Files 122 122
Lines 11007 11018 +11
Branches 934 935 +1
==========================================
+ Hits 9202 9211 +9
- Misses 1494 1495 +1
- Partials 311 312 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saikishor
approved these changes
Dec 8, 2024
Member
saikishor
left a comment
There was a problem hiding this comment.
LGTM in general. Some castings are new to me hahaa
If the CI is happy, I'm fine with it
Member
Author
I used now explicit iterator's |
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
(cherry picked from commit 66d160c) # Conflicts: # forward_command_controller/test/test_load_forward_command_controller.cpp # joint_trajectory_controller/src/trajectory.cpp # tricycle_controller/src/tricycle_controller.cpp
christophfroehlich
added a commit
that referenced
this pull request
Dec 10, 2024
christophfroehlich
pushed a commit
that referenced
this pull request
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, I added the concurrency settings which now automatically cancel running workflows if anything is pushed to PRs.
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs