fix(timeout): do not reset steer wheels to 0. on timeout (backport #1289)#1452
Merged
fix(timeout): do not reset steer wheels to 0. on timeout (backport #1289)#1452
Conversation
Contributor
Author
|
Cherry-pick of 1004054 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
053e8a9 to
5e2adf9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## humble #1452 +/- ##
==========================================
+ Coverage 65.27% 66.72% +1.44%
==========================================
Files 108 113 +5
Lines 12562 13337 +775
Branches 7805 8245 +440
==========================================
+ Hits 8200 8899 +699
+ Misses 1522 1442 -80
- Partials 2840 2996 +156
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
approved these changes
Dec 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of setting the incoming twist command velocity to zero, we should only set the wheel commands to zero without altering the steering angles in order to avoid in-place steering of the wheels.
This is an automatic backport of pull request #1289 done by Mergify.