Skip to content

[JSB] cleanup the activation error message#1584

Merged
christophfroehlich merged 2 commits intoros-controls:masterfrom
pal-robotics-forks:fix/failure_message
Mar 17, 2025
Merged

[JSB] cleanup the activation error message#1584
christophfroehlich merged 2 commits intoros-controls:masterfrom
pal-robotics-forks:fix/failure_message

Conversation

@saikishor
Copy link
Copy Markdown
Member

Fixes #1580

I also cleaned up the other message, as this will never happen, and it would fail much earlier to this activate callback

https://github.com/ros-controls/ros2_control/blob/cc3491c9935b908cba2135fa12f629c7e5063e58/controller_manager/src/controller_manager.cpp#L1916-L1942

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.09%. Comparing base (210358b) to head (88a9b91).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1584      +/-   ##
==========================================
- Coverage   85.12%   85.09%   -0.03%     
==========================================
  Files         124      124              
  Lines       11708    11707       -1     
  Branches      997      999       +2     
==========================================
- Hits         9966     9962       -4     
- Misses       1430     1431       +1     
- Partials      312      314       +2     
Flag Coverage Δ
unittests 85.09% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
..._state_broadcaster/src/joint_state_broadcaster.cpp 88.96% <ø> (-0.79%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit 560fb9f into ros-controls:master Mar 17, 2025
25 checks passed
@christophfroehlich christophfroehlich deleted the fix/failure_message branch March 17, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Joint_state_broadcaster throws error when no states exist, even if none are "requested"

2 participants