Add new members for PID controller parameters (backport #1585)#1769
Merged
christophfroehlich merged 4 commits intojazzyfrom Jun 23, 2025
Merged
Add new members for PID controller parameters (backport #1585)#1769christophfroehlich merged 4 commits intojazzyfrom
christophfroehlich merged 4 commits intojazzyfrom
Conversation
(cherry picked from commit aebe6b1) # Conflicts: # doc/migration.rst # doc/release_notes.rst
Contributor
Author
|
Cherry-pick of aebe6b1 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## jazzy #1769 +/- ##
=======================================
Coverage 84.92% 84.92%
=======================================
Files 127 127
Lines 12175 12175
Branches 1038 1038
=======================================
Hits 10340 10340
Misses 1497 1497
Partials 338 338
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christophfroehlich
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new members to the PID controller parameters to support saturation and three new anti-windup features.
These changes support modifications made to the PID controller in the control_toolbox package. For more details, see ros-controls/control_toolbox#298.
If this PR is approved, it should be merged together with the main PR in the control_toolbox package referenced above.
This is an automatic backport of pull request #1585 done by Mergify.