Skip to content

Change the tests to work without deprecated PID settings (backport #1824)#1825

Merged
christophfroehlich merged 2 commits intojazzyfrom
mergify/bp/jazzy/pr-1824
Jul 22, 2025
Merged

Change the tests to work without deprecated PID settings (backport #1824)#1825
christophfroehlich merged 2 commits intojazzyfrom
mergify/bp/jazzy/pr-1824

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Jul 22, 2025

as per title. I had to fix some test criteria as the integral action is not added at the first update call (integration is done after calculating the command).

needs ros-controls/control_toolbox#432


This is an automatic backport of pull request #1824 done by Mergify.

(cherry picked from commit bf253f1)

# Conflicts:
#	pid_controller/test/test_pid_controller.cpp
#	pid_controller/test/test_pid_controller.hpp
#	pid_controller/test/test_pid_controller_dual_interface.cpp
@mergify mergify Bot added the conflicts label Jul 22, 2025
@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented Jul 22, 2025

Cherry-pick of bf253f1 has failed:

On branch mergify/bp/jazzy/pr-1824
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit bf253f1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   pid_controller/test/pid_controller_params.yaml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   pid_controller/test/test_pid_controller.cpp
	both modified:   pid_controller/test/test_pid_controller.hpp
	both modified:   pid_controller/test/test_pid_controller_dual_interface.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (88ce478) to head (e2a1209).
Report is 1 commits behind head on jazzy.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #1825      +/-   ##
==========================================
- Coverage   85.07%   85.06%   -0.01%     
==========================================
  Files         127      127              
  Lines       12295    12296       +1     
  Branches     1042     1043       +1     
==========================================
  Hits        10460    10460              
  Misses       1497     1497              
- Partials      338      339       +1     
Flag Coverage Δ
unittests 85.06% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pid_controller/test/test_pid_controller.cpp 100.00% <100.00%> (ø)
pid_controller/test/test_pid_controller.hpp 86.13% <100.00%> (ø)
...roller/test/test_pid_controller_dual_interface.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 0b2703f into jazzy Jul 22, 2025
13 of 14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/jazzy/pr-1824 branch July 22, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant