Change the tests to work without deprecated PID settings (backport #1824)#1825
Merged
christophfroehlich merged 2 commits intojazzyfrom Jul 22, 2025
Merged
Change the tests to work without deprecated PID settings (backport #1824)#1825christophfroehlich merged 2 commits intojazzyfrom
christophfroehlich merged 2 commits intojazzyfrom
Conversation
(cherry picked from commit bf253f1) # Conflicts: # pid_controller/test/test_pid_controller.cpp # pid_controller/test/test_pid_controller.hpp # pid_controller/test/test_pid_controller_dual_interface.cpp
Contributor
Author
|
Cherry-pick of bf253f1 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## jazzy #1825 +/- ##
==========================================
- Coverage 85.07% 85.06% -0.01%
==========================================
Files 127 127
Lines 12295 12296 +1
Branches 1042 1043 +1
==========================================
Hits 10460 10460
Misses 1497 1497
- Partials 338 339 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as per title. I had to fix some test criteria as the integral action is not added at the first update call (integration is done after calculating the command).
needs ros-controls/control_toolbox#432
This is an automatic backport of pull request #1824 done by Mergify.