Skip to content

Fix child_frame_id in controller_state_msg (backport #1601)#1834

Merged
christophfroehlich merged 1 commit intohumblefrom
mergify/bp/humble/pr-1601
Jul 25, 2025
Merged

Fix child_frame_id in controller_state_msg (backport #1601)#1834
christophfroehlich merged 1 commit intohumblefrom
mergify/bp/humble/pr-1601

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jul 25, 2025

Closing #504

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

This is an automatic backport of pull request #1601 done by [Mergify](https://mergify.com).

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
(cherry picked from commit 1321ae8)
@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.09%. Comparing base (b0569b2) to head (05807d1).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
...nce_controller/test/test_admittance_controller.cpp 53.33% 0 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1834      +/-   ##
==========================================
- Coverage   67.10%   67.09%   -0.02%     
==========================================
  Files         122      122              
  Lines       14531    14546      +15     
  Branches     8970     8986      +16     
==========================================
+ Hits         9751     9759       +8     
- Misses       1455     1461       +6     
- Partials     3325     3326       +1     
Flag Coverage Δ
unittests 67.09% <63.15%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ude/admittance_controller/admittance_rule_impl.hpp 92.51% <100.00%> (ø)
...nce_controller/test/test_admittance_controller.hpp 93.26% <ø> (ø)
...nce_controller/test/test_admittance_controller.cpp 54.33% <53.33%> (-0.10%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 4aa06d7 into humble Jul 25, 2025
13 of 14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1601 branch July 25, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants