-
Notifications
You must be signed in to change notification settings - Fork 399
Add motion_primitives_from_trajectory_controller
with trajectory approximation using PTP/LIN primitives
#1837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
mathias31415
wants to merge
142
commits into
ros-controls:master
from
b-robotized-forks:motion_primitives_from_trajectory_controller
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time --> added gitignore, to not push it to github --> remove it after everything is done
… the hardware interface can receive a new motion primitive — replaces the previous, more complex handling via execution_status
…ls according to other controllers in the repo
… rtw template to fit the controller implementation
…tation from rtw template to fit the controller implementation
…ontroller namespace
mathias31415
added a commit
to b-robotized-forks/Universal_Robots_ROS2_Driver_MotionPrimitive
that referenced
this pull request
Jul 29, 2025
…s contained in test_motion_primitives_forward_controller
…ives_from_trajectory_controller
Co-authored-by: Felix Exner (fexner) <[email protected]>
…ives_from_trajectory_controller
I plan to split this PR into two separate PRs to make it easier to review:
Nevertheless, the motion_primitves_forward_controller PR should be merged first. |
Co-authored-by: Christoph Fröhlich <[email protected]>
Co-authored-by: Christoph Fröhlich <[email protected]>
Co-authored-by: Christoph Fröhlich <[email protected]>
Co-authored-by: Christoph Fröhlich <[email protected]>
…ives_from_trajectory_controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complements motion_primitives_forward_controller PR #1636 .
Instead of sending hardcoded motion primitives to the
motion_primitives_forward_controller
, this controller (motion_primitives_from_trajectory_controller
) approximates aJointTrajectory
using eitherPTP
orLIN
motion primitives.This allows, for example, collision-free paths planned with MoveIt to be executed as motion primitives. The approximation is performed using the Ramer-Douglas-Peucker (RDP) algorithm:
PTP
primitives in joint spaceLIN
primitives in Cartesian spaceThis PR is marked as a draft for the following reasons:
motion_primitives_base_controller
motion_primitive_controllers
Even though this is still a draft, I would appreciate feedback on the current implementation.