Reset JTC PID's to zero on_activate() (backport #1840)#1843
Merged
christophfroehlich merged 2 commits intohumblefrom Aug 1, 2025
Merged
Reset JTC PID's to zero on_activate() (backport #1840)#1843christophfroehlich merged 2 commits intohumblefrom
christophfroehlich merged 2 commits intohumblefrom
Conversation
(cherry picked from commit 18c9f1f) # Conflicts: # joint_trajectory_controller/src/joint_trajectory_controller.cpp
Contributor
Author
|
Cherry-pick of 18c9f1f has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
MarqRazz
approved these changes
Jul 31, 2025
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## humble #1843 +/- ##
=======================================
Coverage 67.09% 67.09%
=======================================
Files 122 122
Lines 14546 14548 +2
Branches 8984 8987 +3
=======================================
+ Hits 9759 9761 +2
Misses 1461 1461
Partials 3326 3326
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the JTC in velocity control mode I noticed that the joints receive an impulse on reactivation after is has thrown a previous fault in motion. In the below example you can see this joint gets an impulse of -4 rad/sec down to zero as I reactivate the JTC. The impulse causes my hardware to throw another fault.

This change adds a

reset()call to each joints PID controller so that the old command values are zero'd out when (re)activating.This is an automatic backport of pull request #1840 done by [Mergify](https://mergify.com).