set odometry service addition - omni wheel drive controller#2148
Merged
christophfroehlich merged 5 commits intoros-controls:masterfrom Feb 6, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2148 +/- ##
==========================================
- Coverage 84.82% 84.79% -0.03%
==========================================
Files 151 151
Lines 14781 14833 +52
Branches 1280 1286 +6
==========================================
+ Hits 12538 12578 +40
- Misses 1776 1784 +8
- Partials 467 471 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
christophfroehlich
left a comment
There was a problem hiding this comment.
My usual comment ;) rest LGTM
| @@ -33,6 +33,7 @@ class Odometry | |||
| const double & linear_x_vel, const double & linear_y_vel, const double & angular_vel, | |||
| const rclcpp::Time & time); | |||
| void resetOdometry(); | |||
Member
There was a problem hiding this comment.
let's deprecate this and use the set_odometry method instead?
omni_wheel_drive_controller/src/omni_wheel_drive_controller.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
f72f813
into
ros-controls:master
16 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds odometry set service, similar to the other 2 controllers. Related issue.
Features: