Skip to content

set odometry service addition - omni wheel drive controller#2148

Merged
christophfroehlich merged 5 commits intoros-controls:masterfrom
kuralme:set_odom/omni-wheel-drive
Feb 6, 2026
Merged

set odometry service addition - omni wheel drive controller#2148
christophfroehlich merged 5 commits intoros-controls:masterfrom
kuralme:set_odom/omni-wheel-drive

Conversation

@kuralme
Copy link
Contributor

@kuralme kuralme commented Feb 5, 2026

Adds odometry set service, similar to the other 2 controllers. Related issue.
Features:

  • atomic set flag, RealtimeThreadSafeBox usage
  • executed in the update loop
  • testing

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 72.85714% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.79%. Comparing base (3cb8969) to head (c99c193).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ive_controller/src/omni_wheel_drive_controller.cpp 55.26% 11 Missing and 6 partials ⚠️
...ntroller/test/test_omni_wheel_drive_controller.cpp 92.85% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2148      +/-   ##
==========================================
- Coverage   84.82%   84.79%   -0.03%     
==========================================
  Files         151      151              
  Lines       14781    14833      +52     
  Branches     1280     1286       +6     
==========================================
+ Hits        12538    12578      +40     
- Misses       1776     1784       +8     
- Partials      467      471       +4     
Flag Coverage Δ
unittests 84.79% <72.85%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...r/include/omni_wheel_drive_controller/odometry.hpp 100.00% <ø> (ø)
omni_wheel_drive_controller/src/odometry.cpp 81.33% <100.00%> (-4.59%) ⬇️
...ntroller/test/test_omni_wheel_drive_controller.hpp 86.00% <ø> (ø)
...ntroller/test/test_omni_wheel_drive_controller.cpp 99.32% <92.85%> (-0.68%) ⬇️
...ive_controller/src/omni_wheel_drive_controller.cpp 83.01% <55.26%> (-1.09%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My usual comment ;) rest LGTM

@@ -33,6 +33,7 @@ class Odometry
const double & linear_x_vel, const double & linear_y_vel, const double & angular_vel,
const rclcpp::Time & time);
void resetOdometry();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's deprecate this and use the set_odometry method instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christophfroehlich christophfroehlich merged commit f72f813 into ros-controls:master Feb 6, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants