Skip to content

[JSB] Fix joint_state message corruption issue (backport #2217)#2218

Merged
christophfroehlich merged 4 commits intojazzyfrom
mergify/bp/jazzy/pr-2217
Apr 3, 2026
Merged

[JSB] Fix joint_state message corruption issue (backport #2217)#2218
christophfroehlich merged 4 commits intojazzyfrom
mergify/bp/jazzy/pr-2217

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Mar 17, 2026

This fixes the issue reported by @christophfroehlich that sometimes the joint state message is corrupted with incorrect data.

image image
This is an automatic backport of pull request #2217 done by [Mergify](https://mergify.com).

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.41%. Comparing base (2ab5606) to head (a079284).
⚠️ Report is 1 commits behind head on jazzy.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #2218      +/-   ##
==========================================
+ Coverage   84.38%   84.41%   +0.03%     
==========================================
  Files         153      153              
  Lines       15116    15141      +25     
  Branches     1338     1340       +2     
==========================================
+ Hits        12755    12781      +26     
  Misses       1873     1873              
+ Partials      488      487       -1     
Flag Coverage Δ
unittests 84.41% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
..._state_broadcaster/src/joint_state_broadcaster.cpp 88.17% <100.00%> (+0.60%) ⬆️
..._broadcaster/test/test_joint_state_broadcaster.cpp 97.35% <100.00%> (+0.14%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related?

    [ RUN      ] JointStateBroadcasterTest.CorrectMappingWhenInterfaceReadFailsTest
    [INFO] [1773784257.686159051] [joint_state_broadcaster]: Publishing state interfaces defined in 'joints' and 'interfaces' parameters.
    [WARN] [1773784257.686193436] [joint_state_broadcaster]: Mapping from 'position' to interface 'position' will not be done, because 'position' is defined in 'interface' parameter.
Error: ROR] [1773784257.686952976] [joint_state_broadcaster]: Failed to parse robot description. Will publish all the interfaces with 'position', 'velocity' and 'effort'
    terminate called after throwing an instance of 'std::length_error'
      what():  basic_string::_M_create
    Stack trace (most recent call last):

saikishor
saikishor previously approved these changes Apr 2, 2026
@christophfroehlich
Copy link
Copy Markdown
Member

@saikishor tests repeatedly fail with the mentioned error, I've never seen those before

@saikishor
Copy link
Copy Markdown
Member

@saikishor tests repeatedly fail with the mentioned error, I've never seen those before

Sorry, I'll check it in some time

@saikishor saikishor force-pushed the mergify/bp/jazzy/pr-2217 branch from 8c26c0e to a079284 Compare April 3, 2026 15:17
@christophfroehlich
Copy link
Copy Markdown
Member

do we need this fix for the tests in other branches as well?

@christophfroehlich christophfroehlich merged commit 9c610fd into jazzy Apr 3, 2026
14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/jazzy/pr-2217 branch April 3, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants