Skip to content

Remove unnecessary publish_limited_velocity_ member (backport #2266)#2269

Merged
christophfroehlich merged 1 commit intokiltedfrom
mergify/bp/kilted/pr-2266
Apr 2, 2026
Merged

Remove unnecessary publish_limited_velocity_ member (backport #2266)#2269
christophfroehlich merged 1 commit intokiltedfrom
mergify/bp/kilted/pr-2266

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Mar 31, 2026

Summary

  • Removed the redundant publish_limited_velocity_ member from the DiffDriveController.

Changes

  • Removed publish_limited_velocity_ from the header file.
  • Replaced uses of publish_limited_velocity_ with params_.publish_limited_velocity in the implementation.

Closes #2246


This is an automatic backport of pull request #2266 done by Mergify.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.30%. Comparing base (044f98a) to head (42776b8).
⚠️ Report is 8 commits behind head on kilted.

Files with missing lines Patch % Lines
...iff_drive_controller/src/diff_drive_controller.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           kilted    #2269      +/-   ##
==========================================
- Coverage   85.32%   85.30%   -0.02%     
==========================================
  Files         151      151              
  Lines       14831    14832       +1     
  Branches     1281     1282       +1     
==========================================
- Hits        12654    12653       -1     
- Misses       1723     1725       +2     
  Partials      454      454              
Flag Coverage Δ
unittests 85.30% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...iff_drive_controller/src/diff_drive_controller.cpp 82.62% <0.00%> (-0.06%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 31cb74e into kilted Apr 2, 2026
14 of 15 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/kilted/pr-2266 branch April 2, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants