Added test for open-loop odometry with clamped input (backport #2280)#2284
Merged
christophfroehlich merged 4 commits intojazzyfrom Apr 11, 2026
Merged
Added test for open-loop odometry with clamped input (backport #2280)#2284christophfroehlich merged 4 commits intojazzyfrom
christophfroehlich merged 4 commits intojazzyfrom
Conversation
(cherry picked from commit 6c1299f) # Conflicts: # diff_drive_controller/test/test_diff_drive_controller.cpp
Contributor
Author
|
Cherry-pick of 6c1299f has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## jazzy #2284 +/- ##
==========================================
+ Coverage 84.36% 84.52% +0.16%
==========================================
Files 153 153
Lines 15162 15210 +48
Branches 1348 1348
==========================================
+ Hits 12791 12856 +65
+ Misses 1883 1868 -15
+ Partials 488 486 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2279
Description
This PR adds the missing test coverage to verify the open-loop odometry fix.
Implementation Details:
DiffDriveControllerwithopen_loopset totrueand strict velocity limits configured for bothlinear.xandangular.z.Twistcommand that exceeds the configured limits.update()loop and asserts that both the instantaneous velocities (getLinear(),getAngular()) and the integrated positions (getX(),getHeading()) are calculated using the successfully clamped values, not the raw commands.This is an automatic backport of pull request Added test for open-loop odometry with clamped input #2280 done by Mergify.