Skip to content

Added test for open-loop odometry with clamped input (backport #2280)#2284

Merged
christophfroehlich merged 4 commits intojazzyfrom
mergify/bp/jazzy/pr-2280
Apr 11, 2026
Merged

Added test for open-loop odometry with clamped input (backport #2280)#2284
christophfroehlich merged 4 commits intojazzyfrom
mergify/bp/jazzy/pr-2280

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Apr 10, 2026

Closes #2279

Description

This PR adds the missing test coverage to verify the open-loop odometry fix.

Implementation Details:

  • Initializes the DiffDriveController with open_loop set to true and strict velocity limits configured for both linear.x and angular.z.
  • Deliberately publishes a Twist command that exceeds the configured limits.
  • Executes the update() loop and asserts that both the instantaneous velocities (getLinear(), getAngular()) and the integrated positions (getX(), getHeading()) are calculated using the successfully clamped values, not the raw commands.
    This is an automatic backport of pull request Added test for open-loop odometry with clamped input #2280 done by Mergify.

(cherry picked from commit 6c1299f)

# Conflicts:
#	diff_drive_controller/test/test_diff_drive_controller.cpp
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Apr 10, 2026

Cherry-pick of 6c1299f has failed:

On branch mergify/bp/jazzy/pr-2280
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit 6c1299f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   diff_drive_controller/test/test_diff_drive_controller.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.52%. Comparing base (9e7dc55) to head (d401886).
⚠️ Report is 1 commits behind head on jazzy.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #2284      +/-   ##
==========================================
+ Coverage   84.36%   84.52%   +0.16%     
==========================================
  Files         153      153              
  Lines       15162    15210      +48     
  Branches     1348     1348              
==========================================
+ Hits        12791    12856      +65     
+ Misses       1883     1868      -15     
+ Partials      488      486       -2     
Flag Coverage Δ
unittests 84.52% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ive_controller/test/test_diff_drive_controller.cpp 94.92% <100.00%> (+0.70%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit ad40932 into jazzy Apr 11, 2026
13 of 14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/jazzy/pr-2280 branch April 11, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants