Add the job of deleting untagged images #10
Conversation
|
I think we will be able to know whether it is okay by seeing this action's results. Then seems it is ready for you to review. |
.github/workflows/build_images.yaml
Outdated
| owner: 'ros-navigation' | ||
| package-name: 'nav2_docker' | ||
| package-type: 'container' | ||
| min-versions-to-keep: 5 |
|
@SteveMacenski It's ready. |
|
How can I see which images it deleted and which it kept? I'm not seeing any logging I can look to make sure versions that are non-nightly are remaining untouched.
I think looking over the docs you can use regex about which to apply it to / exclude https://github.com/actions/delete-package-versions. It would be extremely problematic if the released versions were deleted, those are very important to keep and not rebuild |
Looks like the only way to learn this is to look at all containers right before running workflow & then right after finishing it's job. I monitored it and I can validate that it only deletes untagged images except the five images built recently. You can take a look my aim board through below link (. The corresponding job doesn't provide any log unfortunately:/)
nightly ones are also tagged, so it will not be deleted. There already no need nightlies being alive for months. Nightlies should live for only a day. And then the new nightly should be generated by removing older nightly. Shortly, as I see, only untagged will be deleted. So, I think there is no regex necessity here imo. |
|
Not to be too pointed (he he he), but if we're not deleting the old nightlies, then what's the point? |
I mean old nightly is untagged and then the image generated recently is tagged. Suppose that we update a tagged one ;) Shortly, with merging this PR, you will get rid of untagged images. At the moment we dont delete the latest 5 untagged image (for sanity check). I can remove if you wish.
|
|
I see that both have tags:
Can you explain to me what 'untagged' then means and how the nightly and the release images differ? I don't see any different configuration of their build and push workflows. |
|
Hello, the nightly and the release images' tags are all the same, no
difference. Sorry for throwing you into this confusion. I couldn't
understand why you think like that. Maybe `job.needs` has made you think
this. So, I am committing some changes in which I added release_docker to
job.needs as well.
Steve Macenski ***@***.***>, 27 May 2025 Sal, 17:40 tarihinde
şunu yazdı:
… *SteveMacenski* left a comment (ros-navigation/nav2_docker#10)
<#10 (comment)>
I see that both have tags:
-
https://github.com/ros-navigation/nav2_docker/blob/main/.github/workflows/build_images.yaml#L39
-
https://github.com/ros-navigation/nav2_docker/blob/main/.github/workflows/build_images.yaml#L157C11-L157C15
Can you explain to me what 'untagged' then means and how the nightly and
the release images differ? I don't see any different configuration of their
build and push workflows.
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIR5IBY4F24J5HMSYGATH3D3AR2MZAVCNFSM6AAAAAB4632NOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMJSG43TKNRXG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Signed-off-by: Cihat Kurtuluş Altıparmak <[email protected]> Signed-off-by: CihatAltiparmak <[email protected]>
Signed-off-by: Cihat Kurtuluş Altıparmak <[email protected]> Signed-off-by: CihatAltiparmak <[email protected]>
Signed-off-by: CihatAltiparmak <[email protected]>
CihatAltiparmak
force-pushed
the
fix/delete_untagged_images
branch
from
eb34d56 to
5fa38c6
Compare
2 participants
DOnt merge for now. closes #9