Merged
Conversation
emersonknapp
changed the title
Member
Author
|
@christophebedard looks like the ghcr.io docker images for setup-ros-docker are private so I couldn't use it for this PR. Should we make those public? |
Member
Author
|
I just went ahead and did it haha |
Member
|
I guess we did it at the same time 😆 I've noticed this before and had to manually make each one public, which I also did now. I guess I missed this after we added the new Noble images. |
Member
|
Can we make all images public by default so that we don't have to manually make future ones public? |
christophebedard
approved these changes
Apr 15, 2025
emersonknapp
force-pushed
the
emerson/ci-ghcr-noble-image
branch
from
3eae0a5 to
7830411
Compare
Use GHCR, which I made into a public package The linter jobs were all named `ament_copyright` Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
force-pushed
the
emerson/ci-ghcr-noble-image
branch
from
7830411 to
81432b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Noble image for proper Rolling build