Skip to content

Unnecessary conditional judgment in isLibraryLoaded ? #173

@daohu527

Description

@daohu527

I wonder num_meta_objs_for_lib_bound_to_loader will always less than num_meta_objs_for_lib, because num_meta_objs_for_lib_bound_to_loader is look forward in allMetaObjectsForLibrary(library_path) and

num_meta_objs_for_lib is equal with allMetaObjectsForLibrary(library_path).size()

bool isLibraryLoaded(const std::string & library_path, ClassLoader * loader)
{
bool is_lib_loaded_by_anyone = isLibraryLoadedByAnybody(library_path);
size_t num_meta_objs_for_lib = allMetaObjectsForLibrary(library_path).size();
size_t num_meta_objs_for_lib_bound_to_loader =
allMetaObjectsForLibraryOwnedBy(library_path, loader).size();
bool are_meta_objs_bound_to_loader =
(0 == num_meta_objs_for_lib) ? true : (
num_meta_objs_for_lib_bound_to_loader <= num_meta_objs_for_lib);

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions