Use 1.75-compatible lockfiles when running Minimal CI#450
Closed
mxgrey wants to merge 4 commits intoros2-rust:mainfrom
Closed
Use 1.75-compatible lockfiles when running Minimal CI#450mxgrey wants to merge 4 commits intoros2-rust:mainfrom
mxgrey wants to merge 4 commits intoros2-rust:mainfrom
Conversation
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Collaborator
Author
|
It seems like colcon-cargo might be ignoring the lockfiles that are present inside of each crate directory, although it's hard to tell for sure since the workflow terminal output gives pretty limited information. In any case the lockfile approach doesn't seem to be working so I'll try a different approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation of the suggestion that I made here that aims to keep the Minimal CI stable even as new versions of dependencies (including transitive dependencies) are released.
The lockfiles are admittedly somewhat annoyingly bulky, especially since each example crate needs one. We should be able to reduce that to a single lockfile if we double this up with the suggestion here to put a workspace at the root of the repo.
I understand that this PR may be controversial, so I'm opening it to test whether it even works and then facilitate discussion about whether or not this is how we'd like to resolve #449, or whether we should consider another approach.