Skip to content

Use 1.75-compatible lockfiles when running Minimal CI #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Use 1.75-compatible lockfiles when running Minimal CI #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9534772
Preserve the lockfile
mxgrey Dec 18, 2024
cdde0e5
Save lockfiles that are compatible with Rust v1.75
mxgrey Dec 18, 2024
276476e
Copy minimal lockfile when running Minimal CI
mxgrey Dec 18, 2024
8f8e65c
Copy minimal lockfile in the first loop through the crates
mxgrey Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/rust-minimal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ jobs:
run: |
for path in $(colcon list | awk '$3 == "(ament_cargo)" { print $2 }'); do
cd $path
cp Cargo.lock.minimal Cargo.lock
rustup toolchain install nightly
cargo +nightly fmt -- --check
cd -
Expand All @@ -90,6 +91,7 @@ jobs:
. /opt/ros/${{ matrix.ros_distribution }}/setup.sh
for path in $(colcon list | awk '$3 == "(ament_cargo)" { print $2 }'); do
cd $path
cp Cargo.lock.minimal Cargo.lock
echo "Running clippy in $path"
# Run clippy for all features except generate_docs (needed for docs.rs)
if [ "$(basename $path)" = "rclrs" ]; then
Expand All @@ -106,6 +108,7 @@ jobs:
. install/setup.sh
for path in $(colcon list | awk '$3 == "(ament_cargo)" && $1 != "examples_rclrs_minimal_pub_sub" && $1 != "examples_rclrs_minimal_client_service" && $1 != "rust_pubsub" { print $2 }'); do
cd $path
cp Cargo.lock.minimal Cargo.lock
echo "Running cargo test in $path"
# Run cargo test for all features except generate_docs (needed for docs.rs)
if [ "$(basename $path)" = "rclrs" ]; then
Expand All @@ -124,6 +127,7 @@ jobs:
. /opt/ros/${{ matrix.ros_distribution }}/setup.sh
for path in $(colcon list | awk '$3 == "(ament_cargo)" && $1 != "examples_rclrs_minimal_pub_sub" && $1 != "examples_rclrs_minimal_client_service" && $1 != "rust_pubsub" { print $2 }'); do
cd $path
cp Cargo.lock.minimal Cargo.lock
echo "Running rustdoc check in $path"
cargo rustdoc -- -D warnings
cd -
Expand Down
Loading
Loading