-
Notifications
You must be signed in to change notification settings - Fork 170
feat: moving examples to its own repo #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Esteve Fernandez <[email protected]>
Can I suggest that we just put a workspace It's much easier to keep the examples in sync with the library when they're collocated. |
@mxgrey at first I tried that, but for some reason I couldn't get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Grey's concern, I guess my hope is that if rclrs
is on track to be feature complete enough and become "the official" Rust library we could aim at having rclrs
examples just be a subfolder of the official examples repo.
@esteve should we clone of the examples into all the distro's repos files so that going forward examples will still be included in rclrs workspaces? That would make it easier to keep things in sync and would make CI fail if a PR broke API but the examples were not updated.
Because of the repo split it will be a bit more churn-y to merge API breakages in both examples and the rclrs library but at least we can catch those.
At the working group meeting last night there was a consensus that we all prefer a cargo workspace solution, but we should prioritize the ability to keep releases happening. So we'll move the examples to their own repo for now, with the expectation that we might move them back after the colcon infrastructure is ready to support it. In the meantime, @luca-della-vedova 's suggestion to add the examples to the But if our strongest preference is to have the examples hosted in this repo as siblings of |
Also happy with a change in the CI to manually clone examples, but as is this introduces potential error surface of introducing breaking changes without fixing the examples |
Signed-off-by: Esteve Fernandez <[email protected]>
I actually thought I had added the examples to the repos files 😅, I just pushed a change (34cb2ee) that adds them. My goal is to keep the CI functionally the same, but moving the examples to another repository to avoid the issues with Cargo workspaces. We can reevaluate later on if we want the examples to be part of the ros2-rust workspace or not when a user clones the repos files, but for now I prefer to not disrupt the dev workflow too much. |
@luca-della-vedova thanks for the review! |
This PR removes the examples , to be merged after ros2-rust/examples#6 is resolved.